EEPROM函数PIC18F25K42是8位但256 k来寻址？XC8-free ASM错误

DATAEE是256字节-不是K字节！



      以下为原文

    DATAEE is 256 Bytes - not kBytes!

这不是我的天；（-）（32度C）



      以下为原文

    this is not my day ;-)
 
(32 degrees C )

如果我发布这样的废话，它不仅是热，而且是一些不工作。使用ICD3，在调试模式EE EE DATAMEMORY视图仍然是所有FF，无论何处（0 - FF），我写。这不是一个刷新问题，因为在代码中读回也显示了FF。在CONFIG://CONT4H中，没有被保护：Traba配置文件WRTB=关闭/ /配置寄存器写保护位-gt；配置寄存器（300 000～3000个BH），不受写保护。引导位-＆GT；未写入保护块（000000×-000 07FFH），未写保护的TraceMac配置，WTDD＝OF//数据EEPROM写保护位-GT；数据EEPROM不写保护，γ-PrAPMA配置WRTFAF＝OU//SAF写保护位-GT；SAF不写保护在MCLR/VPP上的LE位& GT必须用于编程//Op55LπPrimaMac配置Cp= OF//PFM和数据EEPROM代码保护位-GT；PFM和数据EEPROM代码保护DelabDeDelay.该函数被称为DATAEEA写字节（0x00，0x12）；（例如）MCC生成的函数适合数据表（选择）TIN EEPROM，启用写入，解锁，启动写，等待-并且没有中断启用不管怎样）：无效数据DATAEEA写字节（UIT88T BADD，UIT88T BDATA）{UIT88T GiBITValue= InCON0BIT。GIE；NVMADRL =（BADD＆AMP；0xFF）；NVMATAT＝BDATA；NVMCON1BITS。NVMReg＝0；NVMCON1BIT。WREEN＝1；BIG.GEE＝0；//禁用中断NVMCON2= 0x55；NVMCON2= 0xAA；NVMCON1BITS＝1；；/等待写入完成（NVMCON1BIT.WR）{} NVMCON1BIT.WEEN＝0；InCON0BIT。GIG= GIITBITE；//恢复中断使能} PIC有大量的汁液（5.0V）。还尝试在非调试M中运行颂歌。（还激活了ICD3 PREFS中的EEPROM内存保存，因为它的价值）。我错过了什么？



      以下为原文

    If I'm posting nonsense like this it's not just the heat but also something not working.
 
Using ICD3, in debug mode the EE-Datamemory view remains all FF whatever - and wherever (0-FF) I write. It's not a refresh issue since reading back in code reveals FF too.
 
Nothing is protected in the Config:
 
// CONFIG4H
#pragma config WRTB = OFF // Configuration Register Write Protection bit->Configuration registers (300000-30000Bh) not write-protected
#pragma config WRTC = OFF // Boot Block Write Protection bit->Boot Block (000000-0007FFh) not write-protected
#pragma config WRTD = OFF // Data EEPROM Write Protection bit->Data EEPROM not write-protected
#pragma config WRTSAF = OFF // SAF Write protection bit->SAF not Write Protected
#pragma config LVP = OFF // Low Voltage Programming Enable bit->HV on MCLR/VPP must be used for programming
// CONFIG5L
#pragma config CP = OFF // PFM and Data EEPROM Code Protection bit->PFM and Data EEPROM code protection disabled
 
The function is called: DATAEE_WriteByte( 0x00, 0x12); (for example)
 
The MCC generated function fits the datasheet (selecting EEPROM, enabling write, unlocking, launching write, waiting - and there are no interrupts enabled anyway):
 
void DATAEE_WriteByte(uint8_t bAdd, uint8_t bData)
{
uint8_t GIEBitValue = INTCON0bits.GIE;
NVMADRL = (bAdd & 0xFF);
NVMDAT = bData;
NVMCON1bits.NVMREG = 0;
NVMCON1bits.WREN = 1;
INTCON0bits.GIE = 0; // Disable interrupts
NVMCON2 = 0x55;
NVMCON2 = 0xAA;
NVMCON1bits.WR = 1;
// Wait for write to complete
while (NVMCON1bits.WR)
{
}

NVMCON1bits.WREN = 0;
INTCON0bits.GIE = GIEBitValue; // Restore interrupt enable
}
 
The PIC has plenty of juice (5.0v).
 
Have also tried running in non-debug mode. (Have also activated EEPROM memory preservation in ICD3 prefs, for what it's worth).
 
What am I missing?
 

XC8是免费的还是PRO模式？是否检查了汇编代码输出，以查看55 /AA写代码是否完全符合数据表中指定的代码？注意，不能单步执行该代码，必须以全速运行，否则解锁序列将无法工作。



      以下为原文

    Is XC8 in free, or pro mode?
Have you checked the assembly code output, to see if the 55/AA write code is exactly as specified in the datasheet?
 
Note, you can NOT single step that code, it MUST run at full speed, or the unlock sequence won't work.
 

使用XC8免费。DATAEE8BADWEEDE字节（UIT88T BADD，UE88YT BDATA）3E4A6E0MOVWF BADD，Access 165:{UT88T GiBITValue= InCON0BIT。GEE；3E4C 013F MOVLB 0x3F3E4E 0E00 MOVLW 0X03E50BFD2 BTFSC 0xD2，7，BANKED3E52 0E01 MOVLW 0X13E54 6E03 MOVWF C，Access 167：168：NVMADRL =（BADD＆AMP）；程序集如下：空白NVMATAT＝BDATA；3E5E FOP7FOE7F9E3 NOP170：NVMCON1BIT。3E62 0E3F MOVLW 0x3F3E64 0139 MOVLB 0x39 3E66 17E5和WF EXP，F，BANKED171：NVMCON1BIT。WREEN＝1；3E68 0139 MOVLB 0X39 3E6A 85 E5 BSF EXP，2，BANKED172：ItCON0BITI. GEE＝0；/ /禁用中断3E 3E58F0B NOP3E5A F9E0 NOP169MCON2= 0x55；3E700E55 0MVLW 0x55 3E72 0139 MOVLB 0x39 3E74 6FE6 MOVWF 0xE6，BANKED174:NVMCON2= 0xAA；3E76 0EAA MOVLW 0XAA3E78 0139 MOVLB 0X39 3E7A 6FE6 MOVWF 0XE6，BANKED175:NVMCON1BITS WR＝1；3E7C 0139 MOVLB 0X39 3E7E 83E5 BSF EXP，1，BANKED176: 6C013F MOVLB 0x3F3E6E 9FD2 BCF 0xD2，7，BANKED173:NV:等待写入完成177:（NVMCON1BIT.WR）178：{ MVLB 0x93E8B3E5BTFSC EXP，1，BANKED3E8D7FD文胸0x3E80181：182：WEN＝0；3E86MVLB 0x39 3E88 95E5 BCF EXP，2，BANKED183:InCON0BIT.GIE＝GiBIT值；//恢复中断Enable 3E8A B00 3BTF / /SC C，0，Access 3E8C D00 3文胸0x3E943E8E 013F MOVLB 0x3F3E909FD2 BCF 0xD2，7，BANKED3E92 D02文胸0x3E983E94013F MOVLB 0x3F3E96 8FD2 BSF 0xD2，7，BANKED184:}3E98 0012返回实际上这与数据表（P200）大不相同-见下文。讨厌的把戏。我可以将汇编内嵌到C文件中吗？



      以下为原文

    Using XC8 free. Assembly looks as follows:
 
void DATAEE_WriteByte(uint8_t bAdd, uint8_t bData)
3E4A 6E02 MOVWF bAdd, ACCESS
165: {
166: uint8_t GIEBitValue = INTCON0bits.GIE;
3E4C 013F MOVLB 0x3F
3E4E 0E00 MOVLW 0x0
3E50 BFD2 BTFSC 0xD2, 7, BANKED
3E52 0E01 MOVLW 0x1
3E54 6E03 MOVWF c, ACCESS
167:
168: NVMADRL = (bAdd & 0xFF);
3E58 F00B NOP
3E5A F9E0 NOP
169: NVMDAT = bData;
3E5E F007 NOP
3E60 F9E3 NOP
170: NVMCON1bits.NVMREG = 0;
3E62 0E3F MOVLW 0x3F
3E64 0139 MOVLB 0x39
3E66 17E5 ANDWF exp, F, BANKED
171: NVMCON1bits.WREN = 1;
3E68 0139 MOVLB 0x39
3E6A 85E5 BSF exp, 2, BANKED
172: INTCON0bits.GIE = 0; // Disable interrupts
3E6C 013F MOVLB 0x3F
3E6E 9FD2 BCF 0xD2, 7, BANKED
173: NVMCON2 = 0x55;
3E70 0E55 MOVLW 0x55
3E72 0139 MOVLB 0x39
3E74 6FE6 MOVWF 0xE6, BANKED
174: NVMCON2 = 0xAA;
3E76 0EAA MOVLW 0xAA
3E78 0139 MOVLB 0x39
3E7A 6FE6 MOVWF 0xE6, BANKED
175: NVMCON1bits.WR = 1;
3E7C 0139 MOVLB 0x39
3E7E 83E5 BSF exp, 1, BANKED
176: // Wait for write to complete
177: while (NVMCON1bits.WR)
178: {
179:
180: }
3E80 0139 MOVLB 0x39
3E82 B3E5 BTFSC exp, 1, BANKED
3E84 D7FD BRA 0x3E80
181:
182: NVMCON1bits.WREN = 0;
3E86 0139 MOVLB 0x39
3E88 95E5 BCF exp, 2, BANKED
183: INTCON0bits.GIE = GIEBitValue; // Restore interrupt enable
3E8A B003 BTFSC c, 0, ACCESS
3E8C D003 BRA 0x3E94
3E8E 013F MOVLB 0x3F
3E90 9FD2 BCF 0xD2, 7, BANKED
3E92 D002 BRA 0x3E98
3E94 013F MOVLB 0x3F
3E96 8FD2 BSF 0xD2, 7, BANKED
184: }
3E98 0012 RETURN 0
Indeed this differs massively from the datasheet (p200) - see below. Nasty trick.
 
Can I place assembly inline in the C-file? 
   Attached Image(s)

PRO模式会更好。是的。XC8用户指南解释了。



      以下为原文

   
Pro mode would do it better.
 

Yes. The XC8 user guide explains how.

很快就得到了：ItNoNo.Big.NvMCON1；BSF NVMCON1，WREN；MOVLW 0xCO55；MOVWW 0xAA；MOVWF NVMCON2；BSF NVMCON1，WR；α-EnthAs//NVMCON2= 0x55；//NVMCON2= 0xAA；//NVMCON1BIT.WR＝1；/ /等待写入完成（NVMCON1BI）；（175）错误：（800）未定义的符号“WREN”MCCGEN生成的文件/内存。C：181：错误：（800）未定义的符号“WR”MCCGEN生成的文件/内存。C：178：警告：（1352）操作数值（0x39 e6）截断到8位BMSCCZ生成文件/内存。C：180：警告：（1352）截取操作数值（0x39 e6）到8比特，猜想WREN是在汇编语言无法看到的C语言联盟中定义的？因此，在数据表NVM示例中，WREN是一个占位符（比如“55 H”），并且必须用不同的方式来写它吗？但是如何呢？



      以下为原文

    Got this far quite quickly:
 
INTCON0bits.GIE = 0; // Disable interrupts
#asm
BANKSEL NVMCON1;
BSF NVMCON1, WREN;
MOVLW 0x55;

MOVWF NVMCON2;
MOVLW 0xAA;
MOVWF NVMCON2;
BSF NVMCON1, WR;
#endasm
// NVMCON2 = 0x55;
// NVMCON2 = 0xAA;
//NVMCON1bits.WR = 1;
// Wait for write to complete
while (NVMCON1bits.WR)
{
 
But stuck with the following output errors:
 
mcc_generated_files/memory.c:175: error: (800) undefined symbol "WREN"
mcc_generated_files/memory.c:181: error: (800) undefined symbol "WR"
mcc_generated_files/memory.c:178: warning: (1352) truncation of operand value (0x39e6) to 8 bits
mcc_generated_files/memory.c:180: warning: (1352) truncation of operand value (0x39e6) to 8 bits
 
Guess that WREN is defined in a C-language union that the assembly can't see? 
 
So WREN in the datasheet NVM example is a placeholder (like "55h") and one has to write it differently? 
 
But how?
 

只是为了增加我的苦恼——尽管对汇编一无所知——我认为PIC18F25K42数据表的P200上的NVM解锁例程（附加到这个线程的POST×6）包含错误吗？当然：BSF国际CONCO1，WREBBEBSF NVMCON1，WR？？！！



      以下为原文

    Just to add to my woes - and despite zero knowledge of assembly - I think that the NVM unlock routine on p200 of the PIC18F25K42 datasheet (attached to post #6 of this thread) contains an error?
 
Surely:
 
BSF INTCON1, WR 
 
should be
 
BSF NVMCON1, WR 
 
??!!

是的。祝贺你找到第一张数据表。这不会是最后的（文字描述通常是正确的）。这是他们经常留给度假学生填写的示例代码……



      以下为原文

   
Yup. Congratulations on finding your first datasheet SNAFU. It won't be the last.
(The text descriptions are usually correct. It's the example code they often leave for vacation students to fill in...)

这是我的（这是我第一次干预装配）。XC8不喜欢“AAH”，所以我用“0xAA”代替它。然而，它并没有抱怨“55小时”，所以我离开了数据表（也尝试过0x55）！WREEN和WR（未被XC8发现）分别被0B100和0B10所取代，仍然没有写入EEPROM（以及以下输出错误）：MCCGRONGATEATION文件/内存。C：174：警告：（1352）操作数值（0x39 E5）截断到8个BITSMCCH生成的文件/内存。C：178：警告：（1352）截断操作数值（0x39 e6）到8个BITSMCGPROGEDATION文件/内存。C：180：警告：（1352）操作数值（0x39 e6）截断到8位BMSCCH生成的文件/内存。C：182：警告：（1352）操作数值（0x39 E5）截断到8位StudioDATAEED写字节（UIT88T BADD，UIT88T BDATA）{UIT88T GiBITValue= I0；/NVMCON1BITS。NVMCOR1BIT。WREEN＝1；In CONN0BIT。GEE＝0；//禁用中断，γ-BSF NVMCON1，0B100；/MOWLW55；MOVWF NVMCON2；MOVLW 0xAA；MOVWF NVMCON2；BSF NVMCON1，0B10；/WR；γ-EnthAMS//NVMCON2= 0x55；/ / NV NDCON0BITMCON2= 0xAA；//NVMCON1BIT.WR＝1；//等待写入完成（NVMCON1BIT.WR）{} NVMCONNBIT.WREE= 0；InCON0BIT.GIE= GIITBITE；//恢复中断启用}有何建议？



      以下为原文

    This is what I have (and it's the first time I meddle with assembly).
 
XC8 didn't like "AAh" so I replaced it with "0xAA". However it didn't complain about "55h" so I left that as per datasheet (having tried 0x55 as well!).
 
WREN and WR (not found by XC8) were replaced by 0b100 and 0b10 respectively.
 
Still not writing to EEPROM (and the following output errors):
 
mcc_generated_files/memory.c:174: warning: (1352) truncation of operand value (0x39e5) to 8 bits
mcc_generated_files/memory.c:178: warning: (1352) truncation of operand value (0x39e6) to 8 bits
mcc_generated_files/memory.c:180: warning: (1352) truncation of operand value (0x39e6) to 8 bits
mcc_generated_files/memory.c:182: warning: (1352) truncation of operand value (0x39e5) to 8 bits
 
 
void DATAEE_WriteByte(uint8_t bAdd, uint8_t bData)
{
uint8_t GIEBitValue = INTCON0bits.GIE;
NVMADRL = (bAdd & 0xFF);
NVMDAT = bData;
NVMCON1bits.NVMREG = 0;
// NVMCON1bits.WREN = 1;
INTCON0bits.GIE = 0; // Disable interrupts
#asm
BSF NVMCON1, 0b100; //WREN;

MOVLW 55h;

MOVWF NVMCON2;
MOVLW 0xAA;
MOVWF NVMCON2;

BSF NVMCON1, 0b10; //WR;
#endasm
// NVMCON2 = 0x55;
// NVMCON2 = 0xAA;
// NVMCON1bits.WR = 1;
// Wait for write to complete
while (NVMCON1bits.WR)
{
}

NVMCON1bits.WREN = 0;
INTCON0bits.GIE = GIEBitValue; // Restore interrupt enable
}
 
 
Any suggestions?
 
 
 
 
 

CuxEBSF NVMCON1，0B100；/TWSF NVMCON1，2；/WREN；ANDBSF NVMCON1，0B10；//WR；ToPSF NVMCON1，1；/WR；参数是比特数，而不是位掩码。



      以下为原文

    Change
BSF NVMCON1, 0b100; //WREN;
to
BSF NVMCON1, 2; //WREN;
 
and
BSF NVMCON1, 0b10; //WR;
to
BSF NVMCON1, 1; //WR;
 
The argument is the bit number, not a bitmask.
 
 

数字必须从一个数字开始，所以55小时是可以的，但是AAH不是。哦，没关系。



      以下为原文

   
Numbers must start with a digit, so 55h is ok, but AAh is not. 0AAh would be ok.
 

谢谢。下面的代码终于工作了！在数据表的第212页找到另一个NVM示例，并根据迄今为止所学的知识，将中断禁用命令向下移动到ASM序列中的相同位置。这最终做到了。（双重确认通过反转代码更改，将要保存的值更改为EEPROM，验证不写入，重做代码更改，看到写入的新值。）为什么？是另一个问题。是拖延吗？什么是真正的时间序列？不仅仅是55 / AA部分？1000谢谢…今天感觉不太热！EUT88TT BADD，UIT88T BTCONDATE。{NUMADMAL=（BADAD＆AMP；0xFF）；NVMATAT= BDATA；NVMCON1BITS NVMREG＝0；//NVMCON1BITS。WREEN＝1；//ICONCONBITIs。GEE＝0；//禁用中断γ，ASM BSF NVMCON1，2；/BCF ITECON0，7；/GIE，位7 MOVLW 5。无效数据写入5h；MOVWF N0MCON2；MOVWF NVMCON2；BSF NVMCON1；1；//WEAS//NVMCON2= 0x55；//NVMCON2= 0xAA；//NVMCON1BITS＝1；/ /等待写入完成（NVMCON1BIT.WR）{} NVMCON1BITS＝0；InCON0BITI.GIE= GIITBITY；//恢复中断使能}



      以下为原文

    Thanks. The code below finally works! 
 
Found another NVM example on page 212 of datasheet and, emboldened by what learnt so far, moved the Interrupt Disable command down into the identical position in the ASM sequence. That finally did it. 
 
(Double confirmed by reversing the code change, changing the values to be saved to EEPROM, verifying not writing, redoing the code change, seeing new values written.)
 
Why? Is another question. Is it acting as a delay? What is really the sequence that must be critically timed? Not just the 55/AA part?
 
1000 thanks.... It feels less hot today!
 
void DATAEE_WriteByte(uint8_t bAdd, uint8_t bData)
{
uint8_t GIEBitValue = INTCON0bits.GIE;
NVMADRL = (bAdd & 0xFF);
NVMDAT = bData;
NVMCON1bits.NVMREG = 0;
// NVMCON1bits.WREN = 1;
// INTCON0bits.GIE = 0; // Disable interrupts
#asm
BSF NVMCON1, 2; //WREN;

BCF INTCON0, 7; // GIE, bit 7

MOVLW 55h;

MOVWF NVMCON2;
MOVLW 0AAh;
MOVWF NVMCON2;

BSF NVMCON1, 1; //WR;
#endasm
// NVMCON2 = 0x55;
// NVMCON2 = 0xAA;
// NVMCON1bits.WR = 1;
// Wait for write to complete
while (NVMCON1bits.WR)
{
}

NVMCON1bits.WREN = 0;
INTCON0bits.GIE = GIEBitValue; // Restore interrupt enable
}

我不明白为什么移动它会很重要，除了一个版本在C中，另一个版本在汇编程序中。



      以下为原文

    I don't understand why moving it would matter, apart from one version being in C, and the other in assembler.

我也在完全相同的部分上遇到了完全相同的问题。上面提到的解决方案是确保WREEN和GIE标志设置在汇编中使用下面的指令，而不是通过C代码。BSF NVMCON1，2；/WRN；BCF ItCON0，7；/GIE，BIT 7i也观察到如果ItCON0B行。I.GiE＝0；保留在C代码中，代码无法写入EEPROM！因此，似乎解锁序列比一个接一个写55／AA更多。



      以下为原文

    I too faced the exact same issue on exact same part.
The solution as mentioned above, is to ensure that the WREN and GIE flag setting be done using the below instructions in assembly and NOT through C code.
BSF NVMCON1, 2; //WREN;
BCF INTCON0, 7; // GIE, bit 7
 
I also observed that if the line INTCON0bits.GIE= 0; is retained in C code, the code fails to write to EEPROM !
so, it appears that there is more to the unlock sequence than writing 55/AA one after other.

我还没有机会检查，但刚刚了解到，在MCC页面上，您可以下载MCC的新库。库包含部分特定信息来生成代码。问题是，当MCC的新版本出现时，它带有一定的库，但该库不会自动更新，直到MCC插件的下一个版本出现。因此，我们不能自动获得中间库更新，但必须手动下载它们。从内存MCC 3.36到PIC18的库1.45，但有一个可以通过下载安装的1.55库。我想他们有可能解决上述问题吗？；-）



      以下为原文

    I haven't had the chance to check, but have just learnt that on the MCC page you can download new libraries for MCC. The libraries contain part specific information to generate the code. The thing is that when a new version of MCC comes out it comes with a certain library, but that library is not updated automatically until the next version of MCC plugin comes out. So we don't get the intermediate library updates automatically but must download them manually.

From memory MCC 3.36 came with library 1.45 for pic18 but there's a 1.55 library one can install by download. I suppose there's a tiny chance they might have fixed the above issue? ;-)

看起来XC8不太聪明，使用存储的内存指令代替访问内存访问ItCON0。也就是说，修复是必须保证汇编序列访问NVMCONX寄存器的正确的银行，或者通过使用NavkCON1或NACMCON1选择NVMCON1的银行。使用访问RAM来处理ItCON0，以免损坏BSR。



      以下为原文

    It looks like XC8 is not so smart and accesses INTCON0 using banked memory instruction instead of access memory.

172: INTCON0bits.GIE = 0; // Disable interrupts
3E6C 013F MOVLB 0x3F
3E6E 9FD2 BCF 0xD2, 7, BANKED

That is,

INTCON0bits.GIE = 0; // this C line selects bank 63
#asm
BSF NVMCON1, 2; // but NVMCON1 is located in bank 57

So, the fix is you must guarantee the assembly sequence access the correct bank for the NVMCONx registers, either by selecting the bank for NVMCON1 with BANKSEL NVMCON1 or by accessing INTCON0 using the access RAM so not to corrupt BSR.

我想早点寄，但很匆忙。不管怎样，下面我将如何修改MCC生成函数并使用符号来处理汇编位。



      以下为原文

    I wanted to post this earlier, but was in a hurry.  Anyway, here's how I would modify that MCC generated function and use symbols for the assembly bits.
void DATAEE_WriteByte(uint8_t bAdd, uint8_t bData)
{
    NVMADRL = bAdd;
    NVMDAT = bData;
    NVMCON1bits.NVMREG = 0;
    NVMCON1bits.WREN = 1;
 
    #asm
    bcf     STATUS,_STATUS_C_POSN // Save interrupt enable
    btfsc   INTCON0,_INTCON0_GIE_POSN
    bsf     STATUS,_STATUS_C_POSN
    movlw   0x55
    bcf     INTCON0,_INTCON0_GIE_POSN // Disable interrupts

    movwf   NVMCON2
    movlw   0xAA
    movwf   NVMCON2
    bsf     NVMCON1,_NVMCON1_WR_POSN
 
    btfsc   STATUS,_STATUS_C_POSN
    bsf     INTCON0,_INTCON0_GIE_POSN // Restore interrupt enable
    #endasm

    // Wait for write to complete
    while (NVMCON1bits.WR) {}
    NVMCON1bits.WREN = 0;
}